-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Update scilpy & tractometry #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't tested yet. A small comment about naming convention. Don't tested yet. @frheault Could you give me the path of the singularity used for this PR or at least scilpy commit number ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pipeline crash. Maybe a too old version of the models ?
File "/usr/local/lib/python3.7/dist-packages/scilpy-0.2.dev0-py3.7-linux-x86_64.egg/scilpy/segment/voting_scheme.py", line 73, in _init_bundles_tag
for key in self.config.keys():
AttributeError: 'list' object has no attribute 'keys'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked well with the atlas you gave me. Please fix the comments and I will approve after.
@GuillaumeTh Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from my comestic suggestions. This works and was tested with and without the singularity tractoflow-scilpy-rc2
@@ -11,7 +11,7 @@ DESCRIPTION | |||
|
|||
[root] | |||
├── S1 | |||
│ ├── *anat.nii.gz | |||
│ ├── *fa.nii.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it really need to be an FA?
For instance, in my test case, I have b0 and I believe it should work, no?
Can you add something in the help about that please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also,
- Can you provide a link to your zenodo URL please
- Can you add a centroids directory or download on the zenodo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally, a lot of our flows use --root, others use --input. Can we harmonize this?
--input or --root?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
--input
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should work with anything, but I want to leave *fa.nii.gz as an input name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and worked well. Good job ! 🍻
Adaptation to the recent modification in scilpy