Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement suggestions from joss reviewer #13

Merged
merged 13 commits into from
Nov 15, 2023

docs: add clarification in docstring

5d63548
Select commit
Loading
Failed to load commit list.
Merged

implement suggestions from joss reviewer #13

docs: add clarification in docstring
5d63548
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 15, 2023 in 0s

72.61% (-0.04%) compared to 9ced70d

View this Pull Request on Codecov

72.61% (-0.04%) compared to 9ced70d

Details

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (9ced70d) 72.64% compared to head (5d63548) 72.61%.

Files Patch % Lines
dreimac/lenscoords.py 0.00% 3 Missing ⚠️
dreimac/complexprojectivecoords.py 66.66% 1 Missing ⚠️
dreimac/emcoords.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   72.64%   72.61%   -0.04%     
==========================================
  Files          10       10              
  Lines        1053     1048       -5     
  Branches      189      189              
==========================================
- Hits          765      761       -4     
+ Misses        269      268       -1     
  Partials       19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.