Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT parameter validation for covariance.empirical_covariance #25146

Conversation

shogohida
Copy link
Contributor

@shogohida shogohida commented Dec 9, 2022

Signed-off-by: Shogo Hida [email protected]

Reference Issues/PRs

towards #24862

What does this implement/fix? Explain your changes.

Adds parameter validation for covariance.empirical_covariance

Any other comments?

Signed-off-by: Shogo Hida <[email protected]>
Signed-off-by: Shogo Hida <[email protected]>
@shogohida shogohida force-pushed the MAINT-parameters-validation-for-covariance.empirical_covariance branch from 1639749 to 6ec11f6 Compare December 9, 2022 09:17
@jeremiedbb jeremiedbb added the Validation related to input validation label Dec 9, 2022
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @shogohida ! LGTM

@thomasjpfan thomasjpfan changed the title MAINT parameter validation for covariance.empirical_covariance MNT parameter validation for covariance.empirical_covariance Dec 9, 2022
@thomasjpfan thomasjpfan merged commit 17b8278 into scikit-learn:main Dec 9, 2022
@shogohida shogohida deleted the MAINT-parameters-validation-for-covariance.empirical_covariance branch December 9, 2022 14:47
@shogohida
Copy link
Contributor Author

@adrinjalali @thomasjpfan
Thanks guys for your reviews! I hope to contribute to more issues!

Vincent-Maladiere pushed a commit to Vincent-Maladiere/scikit-learn that referenced this pull request Dec 14, 2022
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 3, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
jjerphan pushed a commit to jjerphan/scikit-learn that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants