Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] update user guide, docstrings and comments from undersampling methods #853

Closed
wants to merge 9 commits into from
Closed

[MRG] update user guide, docstrings and comments from undersampling methods #853

wants to merge 9 commits into from

Conversation

solegalli
Copy link
Contributor

@solegalli solegalli commented Aug 10, 2021

What does this implement/fix? Explain your changes.

Updates docstrings, comments and user guide from undersampling methods, except those from ENN, RENN, AllKNN and NCL which are done / mentioned in a separate PR.

Any other comments?

@solegalli
Copy link
Contributor Author

#850 contains updates to ENN, RENN and AllKNN

@solegalli
Copy link
Contributor Author

#764 a parameter needs changing, so skipping update of docstrings ofr NCL here

@solegalli
Copy link
Contributor Author

still need to update NearMiss

@solegalli solegalli changed the title [WIP] update user guide, docstrings and comments from undersampling methods [MRG] update user guide, docstrings and comments from undersampling methods Aug 11, 2021
@solegalli
Copy link
Contributor Author

@glemaitre @chkoar ready for review

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #853 (d52ec25) into master (edf6eae) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #853   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          93       93           
  Lines        6063     6063           
  Branches      508      508           
=======================================
  Hits         5984     5984           
  Misses         78       78           
  Partials        1        1           
Impacted Files Coverage Δ
...rototype_selection/_condensed_nearest_neighbour.py 100.00% <ø> (ø)
...n/under_sampling/_prototype_selection/_nearmiss.py 98.63% <ø> (ø)
...pling/_prototype_selection/_one_sided_selection.py 100.00% <ø> (ø)
...nder_sampling/_prototype_selection/_tomek_links.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edf6eae...d52ec25. Read the comment docs.

@solegalli
Copy link
Contributor Author

@glemaitre would you like me to reopen and update this PR?

@glemaitre
Copy link
Member

Yep I could review it. As mentioned in #850, could you split in several PRs to have small changes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants