-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MRG] update user guide, docstrings and comments from undersampling methods #853
[MRG] update user guide, docstrings and comments from undersampling methods #853
Conversation
#850 contains updates to ENN, RENN and AllKNN |
#764 a parameter needs changing, so skipping update of docstrings ofr NCL here |
still need to update NearMiss |
@glemaitre @chkoar ready for review |
Codecov Report
@@ Coverage Diff @@
## master #853 +/- ##
=======================================
Coverage 98.69% 98.69%
=======================================
Files 93 93
Lines 6063 6063
Branches 508 508
=======================================
Hits 5984 5984
Misses 78 78
Partials 1 1
Continue to review full report at Codecov.
|
@glemaitre would you like me to reopen and update this PR? |
Yep I could review it. As mentioned in #850, could you split in several PRs to have small changes. |
What does this implement/fix? Explain your changes.
Updates docstrings, comments and user guide from undersampling methods, except those from ENN, RENN, AllKNN and NCL which are done / mentioned in a separate PR.
Any other comments?