Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT drop disutils and use scikit-learn fixes instead #1065

Merged
merged 6 commits into from
Mar 31, 2024

Conversation

mr-c
Copy link
Contributor

@mr-c mr-c commented Feb 27, 2024

What does this implement/fix? Explain your changes.

Distutils is deprecated. Use the equivalent function from the packaging package instead. Pytest and others already depend on that, but I added it to the test dependencies to be sure.

Any other comments?

This patch was needed in the Debian package of imbalanced-learn.

This patch was needed in Debian

Co-authored-by: Michael R. Crusoe <[email protected]>
Copy link
Member

@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to make a release for that one.

imblearn/tensorflow/tests/test_generator.py Outdated Show resolved Hide resolved
@glemaitre glemaitre self-requested a review March 30, 2024 17:54
@glemaitre glemaitre changed the title Distutils is deprecated, drop it MAINT drop disutils and use scikit-learn fixes instead Mar 31, 2024
@glemaitre glemaitre merged commit a0e8e0f into scikit-learn-contrib:master Mar 31, 2024
20 of 21 checks passed
glemaitre added a commit that referenced this pull request Mar 31, 2024
Co-authored-by: Nilesh Patra <[email protected]>
Co-authored-by: Guillaume Lemaitre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants