Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ttree title to __doc__ of top level record #836

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Feb 18, 2023

for x = uproot.dask(ttree, ak_add_doc=True) this will cause x to have parameter __doc__ to be set to ttree.title

@lgray lgray changed the title Add ttree title to __doc__ of top level record fix: add ttree title to __doc__ of top level record Feb 18, 2023
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two of these changes shouldn't have any effect (see below)1. Did you observe one?

Footnotes

  1. I'm not saying that it didn't—bugs and oversights happen.

src/uproot/behaviors/TBranch.py Outdated Show resolved Hide resolved
src/uproot/behaviors/TBranch.py Outdated Show resolved Hide resolved
src/uproot/_dask.py Outdated Show resolved Hide resolved
@lgray
Copy link
Contributor Author

lgray commented Feb 21, 2023

OK - was able to remove all the extra bits of paranoia, it works fine without them after a rebase locally.

@jpivarski jpivarski merged commit 68afafc into scikit-hep:main Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants