Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Identifier and "uproot" parameter. #770

Merged
merged 5 commits into from
Oct 29, 2022

Conversation

jpivarski
Copy link
Member

The tests for this PR should pass after scikit-hep/awkward#1845 has been added to a release (probably 2.0.0rc2).

@jpivarski
Copy link
Member Author

The purpose of the "uproot" parameters in the Forms was for Awkward to do the ROOT deserialization, based on the information they contained. That is, this was a pre-AwkwardForth idea, so it really must go away.

@jpivarski jpivarski changed the title chore: remove references to Identifier (once known as Identities). chore: remove Identifier, "uproot" parameter, and ensure non-AwkwardForth fallback works. Oct 28, 2022
@jpivarski
Copy link
Member Author

Note: tests against Awkward main still work.

@jpivarski jpivarski changed the title chore: remove Identifier, "uproot" parameter, and ensure non-AwkwardForth fallback works. chore: remove Identifier and "uproot" parameter. Oct 28, 2022
@jpivarski jpivarski marked this pull request as ready for review October 28, 2022 23:58
@jpivarski
Copy link
Member Author

The tests won't pass until awkward>=2.0.0rc2 is done: https://github.com/scikit-hep/awkward/actions/runs/3349263292

Making coordinated changes across git repos is not great because there must be these in-between times when there's no combination of packages that will work. However, that's why it has to happen now while these are still in pre-release.

@jpivarski
Copy link
Member Author

There will be no more changes to this PR, except if something is needed to get the tests to work. The tests may need to be manually triggered after Awkward 2.0.0rc2 is done.

It's the other half of scikit-hep/awkward#1845.

jpivarski added a commit that referenced this pull request Oct 29, 2022
@jpivarski jpivarski merged commit 049e7fc into main Oct 29, 2022
@jpivarski jpivarski deleted the jpivarski/remove-identifiers-aka-identities branch October 29, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants