fix: Avoid triggering temporary dask-awkward/awkward incompatibility. #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpivarski
deleted the
jpivarski/avoid-triggering-temporary-dask-awkward-awkward-incompatibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dask-awkward assumes that
ak.Array((1, 2, 3))makes anak.Array, the same asak.Array([1, 2, 3]), which is a sensible assumption.scikit-hep/awkward#1614 accidentally changed that, and while one accidental consequence was for the better (
ak.from_iter({"one": 1, "two": 2, "three": 3})no longer returnsak.Array(["one", "two", "three"])), it's reasonable to suppose that a top-level tuple is intended to become anak.Array, especially if passed to theak.Arrayconstructor.scikit-hep/awkward#1642 fixes it (best of both worlds), but Uproot tests would fail until this comes through. Therefore, this fix removes the tests that trigger the incompatibility. It should be merged into any Uproot PRs that are failing because of it.
Removing the
lentests doesn't decrease the power of the test:assert_eqwould not be satisfied if the lengths were different. However, it does reduce coverage of the dask-awkward__len__code.