chore(deps): add xxhash dependency #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The new version of Dask is breaking things. I'll look into it. |
jpivarski
approved these changes
Sep 20, 2024
|
It seems like the Pyodide test that reads a TTree over http is a little finicky. I think the server is not fast enough and it ends up timing out since there's some overhead from running things in Pyodide. I've seen it fail a few times in the CI already. I'll replace it with one that gets a smaller file from GitHub to ensure it's more stable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xxhashis currently a strict dependency for reading RNTuples (see #1271). We could simply remove the line that usesxxhashto verify checksums, but given that it is now available in Pyodide and it will unquestionably be needed for writing RNTuples, then it makes sense to add it as a dependency now.Once this is merged, I will also start using it more extensively for RNTuple reading.
Closes #1271.