Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: set _max_workers in ThreadPoolExecutor with non-None initializer #1254

Merged
merged 3 commits into from
Jul 23, 2024
Merged

fix: set _max_workers in ThreadPoolExecutor with non-None initializer #1254

merged 3 commits into from
Jul 23, 2024

Conversation

NJManganelli
Copy link
Contributor

Looks like this was missing when the function got rebuilt. A test added with None and 1 max_workers arguments in the style of PR#1120, let me know if names should be changed

@jpivarski jpivarski changed the title Set _max_workers in ThreadPoolExecutor with non-None initializer fix: set _max_workers in ThreadPoolExecutor with non-None initializer Jul 23, 2024
jpivarski
jpivarski approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's right! If max_workers is given, you want the ThreadPoolExecutor to actually use it.

With the PR title fixed, this should pass all cuts, and I'll merge it as soon as it does.

@jpivarski jpivarski merged commit 0a997cd into scikit-hep:main Jul 23, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpivarski jpivarski jpivarski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NJManganelli @jpivarski