Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use ruff instead of flake8,black,isort,pyupgrade,nbQA,etc. #263

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 7, 2024

Simpler, faster, less to manage.

Close #247.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@henryiii henryiii changed the title chore: use ruff instead of flake8,black,isort,pyupgrade,etc. chore: use ruff instead of flake8,black,isort,pyupgrade,nbQA,etc. Oct 7, 2024
src/pylhe/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: Henry Schreiner <[email protected]>
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.77%. Comparing base (19ba795) to head (805bfd4).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pylhe/__init__.py 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #263      +/-   ##
==========================================
+ Coverage   91.08%   91.77%   +0.68%     
==========================================
  Files           2        2              
  Lines         303      304       +1     
  Branches       83       81       -2     
==========================================
+ Hits          276      279       +3     
  Misses         17       17              
+ Partials       10        8       -2     
Flag Coverage Δ
unittests-3.10 91.44% <92.59%> (+0.68%) ⬆️
unittests-3.11 91.44% <92.59%> (+0.68%) ⬆️
unittests-3.12 91.44% <92.59%> (+0.68%) ⬆️
unittests-3.8 91.44% <92.59%> (+0.68%) ⬆️
unittests-3.9 91.44% <92.59%> (+0.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henryiii
Copy link
Member Author

henryiii commented Oct 7, 2024

FYI, I might not have included the absolute import check, it's somewhere in Ruff, but I don't use it, so not sure where it is.

@matthewfeickert
Copy link
Member

@henryiii thanks for this PR! I'm in transit but I can also review this later on this week, though seems @APN-Pucky is already in it. 👍

@APN-Pucky
Copy link
Member

LGTM, Thanks!

@APN-Pucky APN-Pucky merged commit 906e919 into main Oct 8, 2024
14 checks passed
@APN-Pucky APN-Pucky deleted the henryiii/chore/ruff branch October 8, 2024 09:40
@eduardo-rodrigues eduardo-rodrigues added the CI Continuous Integration label Oct 8, 2024
@eduardo-rodrigues
Copy link
Member

(Just added a label - we try and keep it tidy :).)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change formatting to use Ruff
4 participants