Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add 3.13 classifier and test #262

Merged
merged 1 commit into from
Oct 8, 2024
Merged

chore: add 3.13 classifier and test #262

merged 1 commit into from
Oct 8, 2024

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Oct 7, 2024

Adding 3.13, which was released today.

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (d5bcb8e) to head (17a8088).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files           2        2           
  Lines         304      304           
  Branches       81       81           
=======================================
  Hits          279      279           
  Misses         17       17           
  Partials        8        8           
Flag Coverage Δ
unittests-3.10 91.44% <ø> (ø)
unittests-3.11 91.44% <ø> (ø)
unittests-3.12 91.44% <ø> (ø)
unittests-3.13 91.44% <ø> (?)
unittests-3.8 91.44% <ø> (ø)
unittests-3.9 91.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@APN-Pucky APN-Pucky self-requested a review October 8, 2024 09:49
@APN-Pucky
Copy link
Member

@henryiii Do you think lint.yml and publish-package.yml should also already change to python-version: '3.13'?

@APN-Pucky APN-Pucky added the chore label Oct 8, 2024
@henryiii
Copy link
Member Author

henryiii commented Oct 8, 2024

That needs a bit more time, IMO, since GHA needs to start providing builds of 3.13.0 in the runner images so that they are fast. Currently it has to download, which takes a few extra seconds. (You can use "3.x", which should get the latest version present).

@APN-Pucky APN-Pucky merged commit 7802b7e into main Oct 8, 2024
14 checks passed
@APN-Pucky APN-Pucky deleted the henryiii/ci/313 branch October 8, 2024 19:13
@henryiii
Copy link
Member Author

henryiii commented Oct 8, 2024

It would be good to get patch release in the near future with the classifier since 3.13 is out! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants