Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set only lower bounds on core dependencies #113

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 7, 2022

c.f. scikit-hep/pyhf#1382 for description of general motivation.

Also updates lower bound on particle as originally recommended in PR #108.

* Place only lower bounds (>=) on all core dependencies in setup.cfg.
* Update lower bond on particle to v0.16 to ensure compliance with the
2021 version of the PDG.

Co-authored-by: Eduardo Rodrigues <[email protected]>

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #113 (ec5aaaa) into master (a7a4f0f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   60.39%   60.39%           
=======================================
  Files           2        2           
  Lines         202      202           
  Branches       55       55           
=======================================
  Hits          122      122           
  Misses         72       72           
  Partials        8        8           
Flag Coverage Δ
unittests 60.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a4f0f...ec5aaaa. Read the comment docs.

@matthewfeickert matthewfeickert merged commit f606a06 into master Mar 7, 2022
@matthewfeickert matthewfeickert deleted the build/update-lower-bound-on-particle branch March 7, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant