build: Restrict TensorFlow to v2.2.X and TensorFlow Probability to v0.10.X #999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewfeickert
added
the
build
Codecov Report
@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 96.65% 96.65%
=======================================
Files 59 59
Lines 3284 3284
Branches 455 455
=======================================
Hits 3174 3174
Misses 69 69
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
kratsg
approved these changes
Jul 27, 2020
lukasheinrich
approved these changes
Jul 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #998
As Issue #997 makes it clear that minor releases might as well be major releases for TensorFlow, then it is probably worth keeping tighter version constraints on TensorFlow and TensorFlow Probability release ranges and just watching the releases of both libraries TensorFlow and TensorFlow Probability to see when we can relax these.
Note that Issue #997 won't be resolved until TensorFlow Probability
v0.11.0can be released, and as a result of this the current release workflows will also be broken untilv0.11.0is released. This is a good illustration of the point that with TensorFlow we need to be more restirctive.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: