Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add kwarg for AsymptoticCalculator base distribution #993

Merged
merged 18 commits into from
Feb 14, 2021
Merged

feat: Add kwarg for AsymptoticCalculator base distribution #993

merged 18 commits into from
Feb 14, 2021

Commits on Feb 11, 2021

  1. calculator kwargs

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3838094 View commit details
    Browse the repository at this point in the history

  2. 1000!

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3152982 View commit details
    Browse the repository at this point in the history

  3. more content

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    023198f View commit details
    Browse the repository at this point in the history

  4. default value

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    345ed4c View commit details
    Browse the repository at this point in the history

  5. make tests pass

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    3fabda9 View commit details
    Browse the repository at this point in the history

  6. what

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    b40ce2a View commit details
    Browse the repository at this point in the history

  7. clipped test

    @lukasheinrich @matthewfeickert
    lukasheinrich authored and matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2541786 View commit details
    Browse the repository at this point in the history

  8. Drop calc_kwargs for base_distr keyword after rebase 

    As kwargs are now used it is easier to just add a "base_distr" keyword
arg rather than adding a calc_kwargs specifically.
    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    01ff7e5 View commit details
    Browse the repository at this point in the history

  9. Rename base_distr kwarg to calc_base_dist 

    Seems more explicit, to Feickert at least
    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2764b7a View commit details
    Browse the repository at this point in the history

  10. Fix doctest

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    ab0c104 View commit details
    Browse the repository at this point in the history

  11. Make test_clipped_normal_calc more verbose

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    8c434c6 View commit details
    Browse the repository at this point in the history

  12. Correct AsymptoticCalculator docstring to use test_stat not qtilde 

    The bool qtilde is now no longer used and so should be removed
    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    204fe39 View commit details
    Browse the repository at this point in the history

  13. Correct ToyCalculator docstring to use test_stat not qtilde

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    c7ec4a0 View commit details
    Browse the repository at this point in the history

  14. Add docstring for calc_base_dist kwarg behavior

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    d5ae4a5 View commit details
    Browse the repository at this point in the history

  15. Revise text on calc_base_dist

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    887c1c2 View commit details
    Browse the repository at this point in the history

  16. Bullet-ize test_stat docstring

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    0c1a0e1 View commit details
    Browse the repository at this point in the history

  17. Add colons

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    5335701 View commit details
    Browse the repository at this point in the history

  18. Correct to mu-hat/sigma space

    @matthewfeickert
    matthewfeickert committed Feb 11, 2021
    Configuration menu
    Copy the full SHA
    2d4e6fd View commit details
    Browse the repository at this point in the history