Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use codecov-cli for coverage report upload #2260

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthewfeickert
Copy link
Member

Description

Resolves #2256

Use codecov-cli to upload coverage report over codecov/codecov-action GitHub Action to be able to make future use of Codecov ATS.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use codecov-cli to upload coverage report over codecov/codecov-action
  GitHub Action to be able to make future use of Codecov ATS.
   - c.f. https://docs.codecov.com/docs/the-codecov-cli

* Use codecov-cli to upload coverage report over codecov/codecov-action
  GitHub Action to be able to make future use of Codecov ATS.
   - c.f. https://docs.codecov.com/docs/the-codecov-cli
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Jul 20, 2023
@matthewfeickert matthewfeickert self-assigned this Jul 20, 2023
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Jul 20, 2023

Hm. A concern I have is that this is installing a lot of dependencies, where the GitHub Action removes that from our environment. This is what happens when it is installed in an empty Python 3.11 virtual environment.

(venv) root@1ba964ac7c35:/# python -m pip list
Package            Version
------------------ --------
anyio              3.7.1
certifi            2023.5.7
charset-normalizer 3.2.0
click              8.1.6
codecov-cli        0.1.16
coverage           7.2.7
h11                0.14.0
httpcore           0.16.3
httpx              0.23.3
idna               3.4
ijson              3.2.2
iniconfig          2.0.0
packaging          23.1
pip                23.2
pluggy             1.2.0
pytest             7.4.0
pytest-cov         3.0.0
PyYAML             6.0.1
requests           2.31.0
responses          0.21.0
rfc3986            1.5.0
setuptools         68.0.0
smart-open         6.3.0
sniffio            1.3.0
tree-sitter        0.20.1
urllib3            2.0.4
wheel              0.40.0
(venv) root@1ba964ac7c35:/#

Many of these are pinned to major or minor versions, which means that this is going to cause pain in the CI process. I think that I would prefer to avoid this and just use pipx or something if this is really necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Use the Codecov CLI to upload coverage
1 participant