Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use jax.errors API as jax._src removed from public namespace #2034

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 26, 2022

Description

Resolves #2033

This only affects the tests as jax.errors.TracerArrayConversionError works in the JAX v0.2.10 API, so nothing needs to be altered elsewhere.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Use jax.errors API over jax._src.errors as jax._src is removed from the
  jax public namespace in jax v0.3.18.
   - c.f. https://github.com/google/jax/releases/tag/jax-v0.3.18

@matthewfeickert matthewfeickert added tests pytest fix A bug fix labels Sep 26, 2022
@matthewfeickert matthewfeickert self-assigned this Sep 26, 2022
@matthewfeickert matthewfeickert changed the title fix: Use jax.errors as jax 0.3.18 removes import of jax._src fix: Use jax.errors API as jax._src removed from public namespace Sep 26, 2022
@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 98.30% // Head: 98.30% // No change to project coverage 👍

Coverage data is based on head (6164930) compared to base (2d791e8).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2034   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files          69       69           
  Lines        4530     4530           
  Branches      738      738           
=======================================
  Hits         4453     4453           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 27.52% <ø> (ø)
doctest 61.14% <ø> (ø)
unittests-3.10 96.31% <ø> (ø)
unittests-3.7 96.28% <ø> (ø)
unittests-3.8 96.33% <ø> (ø)
unittests-3.9 96.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@matthewfeickert matthewfeickert modified the milestones: v0.8.0, v0.7.1 Sep 26, 2022
@matthewfeickert
Copy link
Member Author

As this is just updating an API only used in the tests and that passes on the minimum supported dependencies workflow, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert merged commit d088b17 into main Sep 26, 2022
@matthewfeickert matthewfeickert deleted the fix/jax-_src branch September 26, 2022 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix A bug fix tests pytest
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

JAX v0.3.18 contains breaking change that fails CI
1 participant