Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add PR number to Semantic PR Title Check concurrency group #1981

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

kratsg
Copy link
Contributor

@kratsg kratsg commented Sep 2, 2022

Pull Request Description

The Semantic PR Check is cancelling itself on other PRs because the concurrency is based on target branch only, rather than the PR number as well.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add PR number to Semantic PR Title Check concurrency to avoid unintended cancellation.

@kratsg kratsg added CI CI systems, GitHub Actions fix A bug fix labels Sep 2, 2022
@kratsg kratsg self-assigned this Sep 2, 2022
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks @kratsg!

Though let's let the CI finish running to avoid causing huge backlogs in the CI queue.

@matthewfeickert matthewfeickert changed the title fix: Semantic PR Title Check conccurency needs to include PR number fix: Add PR number to Semantic PR Title Check concurrency group Sep 2, 2022
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Base: 98.24% // Head: 98.24% // No change to project coverage 👍

Coverage data is based on head (c167a89) compared to base (b1d6bd4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1981   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          68       68           
  Lines        4378     4378           
  Branches      726      726           
=======================================
  Hits         4301     4301           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 26.58% <ø> (ø)
doctest 60.57% <ø> (ø)
unittests-3.10 96.13% <ø> (ø)
unittests-3.7 96.12% <ø> (ø)
unittests-3.8 96.16% <ø> (ø)
unittests-3.9 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kratsg kratsg merged commit c68e43b into master Sep 2, 2022
@kratsg kratsg deleted the fix/SemanticPRConcurrency branch September 2, 2022 21:10
@matthewfeickert
Copy link
Member

@kratsg remember for these one commit PRs that if you just merge without checking the commit message that it just takes the commit message and not the PR message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants