-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add type hints for tensor manager #1963
Conversation
b4e021f
to
87e857a
Compare
Codecov ReportBase: 98.26% // Head: 98.26% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1963 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 68 68
Lines 4430 4430
Branches 728 728
=======================================
Hits 4353 4353
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dea50df
to
ccda178
Compare
e8e24b5
to
1a204e3
Compare
fda658c
to
fafe35f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍 Thanks @kratsg!
Pull Request Description
See #1284.
This PR adds typing for
src/pyhf/tensor/manager.py
(and also adds some typing for thesrc/pyhf/events.py
to make sure the decorators used are forwarding their signatures).Additionally provides some minor fix on top of #1940 to get the NumPy backend more properly typed according to the expanded (stricter)
TensorBackend
Protocol
.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: