Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update lower bound of typing-extensions to v3.7.4.3 #1961

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

matthewfeickert
Copy link
Member

Description

Update lower bound of the supported typing-extensions versions to v3.7.4.3 to ensure SupportsIndex is available, which is used as of PR #1940.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update lower bound of the supported typing-extensions versions to v3.7.4.3
  to ensure SupportsIndex is available, which is used as of PR #1940.
   - Amends PR #1940.
* Update tests/constraints.txt to use typing-extensions==3.7.4.3.

* Update lower bound of the supported typing-extensions versions to v3.7.4.3
  to ensure SupportsIndex is available, which is used as of PR 1940.
@matthewfeickert matthewfeickert added fix A bug fix build Changes that affect the build system or external dependencies labels Aug 26, 2022
@matthewfeickert matthewfeickert self-assigned this Aug 26, 2022
@matthewfeickert matthewfeickert temporarily deployed to github-pages August 26, 2022 20:02 Inactive
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Aug 26, 2022

PR #1962 is a follow up PR to this to deal with the fact that numpy.typing was introduced in numpy v1.20.0.

@codecov
Copy link

codecov bot commented Aug 26, 2022

Codecov Report

Merging #1961 (467116a) into master (fc9ffd1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1961   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files          68       68           
  Lines        4380     4380           
  Branches      728      728           
=======================================
  Hits         4303     4303           
  Misses         45       45           
  Partials       32       32           
Flag Coverage Δ
contrib 26.55% <ø> (ø)
doctest 60.54% <ø> (ø)
unittests-3.10 96.14% <ø> (ø)
unittests-3.7 96.12% <ø> (ø)
unittests-3.8 96.16% <ø> (ø)
unittests-3.9 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kratsg kratsg merged commit a92d9b2 into master Aug 26, 2022
@kratsg kratsg deleted the build/update-typing-extensions-lower-bound branch August 26, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Changes that affect the build system or external dependencies fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants