-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Update git archival options to support auto versioning #1951
Conversation
@henryiii I know you were updating sections for |
Codecov Report
@@ Coverage Diff @@
## master #1951 +/- ##
=======================================
Coverage 98.26% 98.26%
=======================================
Files 69 69
Lines 4439 4439
Branches 748 748
=======================================
Hits 4362 4362
Misses 45 45
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
* Given 'Add support for pyproject.toml configuration' - c.f. https://setuptools.pypa.io/en/latest/history.html#v61-0-0
There's no harm in older versions, they just don't look for this file. But since you are Python 3.7+ already, don't see a harm in requiring setuptools_scm>=7 if you want to.
But you aren't using it? |
Correct, but we eventually will and I will probably forget to update the lower bound when switching. I only thought to do so here as I was reading the Scikit-HEP developer guide again. |
Description
Resolves #1914
From the removed sections of scikit-hep/scikit-hep.github.io#250 I see that we should be updating the
.git_archival.txt
information to allow for Git archives (including the ones generated from GitHub) to also support versioning. c.f. https://github.com/pypa/setuptools_scm/tree/1b18371fc2fa672f39c758a103c4d12956b5964f#git-archivesIn there it is additionally pointed out (in the removed section) that
So additionally update
build-system
requires
to havesetuptools_scm>=7.0.1
as7.0.0
was yanked.Require
setuptools>=61.0.0
for the build system asv61.0.0
adds support forpyproject.toml
configuration. This configuration is not currently used by pyhf, but it is updated given the recommendation by the Scikit-HEP developer guide.Checklist Before Requesting Reviewer
Before Merging
For the PR Assignees: