Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Set English as language for Sphinx #1875

Merged
merged 2 commits into from
May 30, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented May 30, 2022

Description

Set 'en' - English as the language for the docs. In Sphinx v5.0.0+ setting a language is required to avoid:

WARNING: Invalid configuration value found: 'language = None'

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Set 'en' - English as the language for the docs. In Sphinx v5.0.0+ setting
a language is required to avoid:
> WARNING: Invalid configuration value found: 'language = None'

* Set 'en' - English as the language for the docs. In Sphinx v5.0.0+
setting a language is required to avoid:
> WARNING: Invalid configuration value found: 'language = None'
@matthewfeickert matthewfeickert added the docs Documentation related label May 30, 2022
@matthewfeickert matthewfeickert self-assigned this May 30, 2022
@matthewfeickert
Copy link
Member Author

As other maintainers are on holiday, I'm going to approve and merge this myself. As always, PRs approved by a single core dev can be reverted as needed by the rest of the dev team.

@matthewfeickert matthewfeickert added the fix A bug fix label May 30, 2022
@codecov
Copy link

codecov bot commented May 30, 2022

Codecov Report

Merging #1875 (9ce30e9) into master (fd99262) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1875   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd99262...9ce30e9. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 654af5c into master May 30, 2022
@matthewfeickert matthewfeickert deleted the docs/update-sphinx-requirements branch May 30, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant