Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add semantic PR check GHA workflow #1868

Merged
merged 3 commits into from
May 26, 2022

Conversation

matthewfeickert
Copy link
Member

Description

As https://github.com/zeke/semantic-pull-requests is no longer maintained and is down (c.f. zeke/semantic-pull-requests#183 (comment)), use the suggested alternative of https://github.com/amannn/action-semantic-pull-request to check that PR titles follow the Conventional Commits spec.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* As https://github.com/zeke/semantic-pull-requests is no longer maintained
and is down, use the suggested alternative of
https://github.com/amannn/action-semantic-pull-request to check that PR titles
follow the Conventional Commits spec.

* As https://github.com/zeke/semantic-pull-requests is no longer maintained
and is down, use the suggested alternative of
https://github.com/amannn/action-semantic-pull-request to check that PR titles
follow the Conventional Commits spec.
@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label May 25, 2022
@matthewfeickert matthewfeickert self-assigned this May 25, 2022
@codecov
Copy link

codecov bot commented May 25, 2022

Codecov Report

Merging #1868 (5c45bb6) into master (0409ab5) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   98.17%   98.17%           
=======================================
  Files          68       68           
  Lines        4322     4322           
  Branches      726      726           
=======================================
  Hits         4243     4243           
  Misses         46       46           
  Partials       33       33           
Flag Coverage Δ
contrib 26.39% <ø> (ø)
doctest 60.73% <ø> (ø)
unittests-3.10 96.04% <ø> (ø)
unittests-3.7 96.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0409ab5...5c45bb6. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 45e0e3c into master May 26, 2022
@matthewfeickert matthewfeickert deleted the ci/add-conventional-commit-check branch May 26, 2022 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants