Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Lukas's affiliation to Technical University of Munich #1798

Merged
merged 3 commits into from
Mar 2, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Mar 2, 2022

Description

Lukas is a professor at Technical University of Munich now! (:tada:) so we should update his institute affiliations for citation.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Lukas Heinrich is a professor at Technical University of Munich as of 2022!

@matthewfeickert matthewfeickert added the docs Documentation related label Mar 2, 2022
@matthewfeickert matthewfeickert self-assigned this Mar 2, 2022
@@ -6,7 +6,7 @@
"upload_type": "software",
"creators": [
{
"affiliation": "CERN",
"affiliation": "Technical University of Munich",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lukasheinrich Technical University of Munich or Technische Universität München?

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1798 (c74b42d) into master (d0c4efa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1798   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0c4efa...c74b42d. Read the comment docs.

@matthewfeickert matthewfeickert merged commit 8dedfeb into master Mar 2, 2022
@matthewfeickert matthewfeickert deleted the docs/update-Lukas-affiliation branch March 2, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants