Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add section for tutorial and docs to README #1789

Merged
merged 5 commits into from
Feb 25, 2022

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Feb 24, 2022

Description

Resolves #1782

Add a "User Guide" section as the very first section in the README that link to the pyhf tutorial. Also add badge to the Jupyter Book tutorial to the top of the README. Jupyter Book Badge

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add section to README that links to the pyhf tutorial.
   - c.f. https://pyhf.github.io/pyhf-tutorial/
* Add badge to the Jupyter Book tutorial to the top of the README.
* Add section to README that explicitly links to the documentation.
   - c.f. https://pyhf.readthedocs.io/

* Add badge to the Jupyter Book tutorial to the top of the README.
@matthewfeickert matthewfeickert added the docs Documentation related label Feb 24, 2022
@matthewfeickert matthewfeickert self-assigned this Feb 24, 2022
@matthewfeickert
Copy link
Member Author

matthewfeickert commented Feb 24, 2022

Relevant RTD build: https://pyhf--1789.org.readthedocs.build/en/1789/ so people can get a feel of the style.

User Guide
----------

For an in depth walkthrough of usage of the latest release of ``pyhf`` visit the |pyhf tutorial|_.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to sync language here

$ git grep 'in depth walkthrough'
.github/ISSUE_TEMPLATE/config.yml:    The pyhf tutorial is continually updated and provides an in depth walkthrough
README.rst:For an in depth walkthrough of usage of the latest release of ``pyhf`` visit the |pyhf tutorial|_.

but happy to change it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me.

@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1789 (55a3cb1) into master (2533bd9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1789   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2533bd9...55a3cb1. Read the comment docs.

User Guide
----------

For an in depth walkthrough of usage of the latest release of ``pyhf`` visit the |pyhf tutorial|_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering whether it also makes sense to directly link the readthedocs here? The tutorial does so in the first line. It is also in the questions section in the readme as well as in the badges, but both of those are slightly more hidden compared to this new entry. A user will definitely find it regardless, but the benefit I see from also linking the RTD here is that they can be contrasted a bit so a user knows which website is more appropriate for their specific needs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea. I put it lower down so that a reader would be hit first by the user guide, then by examples, and then by the docs. Very happy for other thoughts here though. 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No strong opinion here, I think it is fine as-is. I personally think that the "What does it support" section is expert-level material, and that there is a lot of scrolling needed to get to the docs section, but ultimately it is just personal opinion. Users should be able to comfortably find what they are looking for with the layout implemented here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I agree with you here. 👍 As that will take more thought then I think I have in me now, I've bumped that to Issue #1791.

@matthewfeickert matthewfeickert changed the title docs: Add section for tutorial to README docs: Add section for tutorial and docs to README Feb 25, 2022
README.rst Outdated Show resolved Hide resolved
Co-authored-by: Alexander Held <[email protected]>
@matthewfeickert matthewfeickert merged commit 9fd99be into master Feb 25, 2022
@matthewfeickert matthewfeickert deleted the docs/add-tutorial-link-to-README branch February 25, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tutorial link to README
3 participants