Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix link to TRExFitter documentation #1777

Merged

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Feb 15, 2022

Description

The TRExFitter part of the translation section in the documentation contains a link to ATLAS-internal documentation. Following a restructuring of that internal documentation, the link used on the pyhf website is no longer correct. This fixes the link.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Update URL to 'TRExFitter to pyhf' translation docs
   - c.f. https://trexfitter-docs.web.cern.ch/trexfitter-docs/interfacing_tools/pyhf/

@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1777 (de51956) into master (c2c2891) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1777   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          64       64           
  Lines        4270     4270           
  Branches      683      683           
=======================================
  Hits         4190     4190           
  Misses         46       46           
  Partials       34       34           
Flag Coverage Δ
contrib 26.25% <ø> (ø)
doctest 60.58% <ø> (ø)
unittests 96.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2c2891...de51956. Read the comment docs.

Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks!

@matthewfeickert matthewfeickert merged commit 2fa1c96 into scikit-hep:master Feb 15, 2022
@alexander-held alexander-held deleted the docs/trexfitter-link branch February 15, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related fix A bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants