Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: only lists are accepted when specifying objects to prune #1692

Merged

Conversation

alexander-held
Copy link
Member

@alexander-held alexander-held commented Nov 11, 2021

Description

Resolves #1684.

As confirmed by @kratsg, the pruning API was meant to take lists to specify which modifiers / samples etc. are meant to be pruned, and to not support strings in addition to that. This updates the docstrings in the public and internal API to reflect the implementation: as shown in the example in #1684, only lists are supported.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Correct Workspace.prune docstrings to indicate lists are accepted

@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #1692 (e176353) into master (39a9e92) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1692   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files          64       64           
  Lines        4220     4220           
  Branches      587      587           
=======================================
  Hits         4138     4138           
  Misses         49       49           
  Partials       33       33           
Flag Coverage Δ
contrib 25.35% <ø> (ø)
doctest 61.13% <ø> (ø)
unittests 96.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pyhf/workspace.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39a9e92...e176353. Read the comment docs.

@matthewfeickert matthewfeickert added the docs Documentation related label Nov 11, 2021
Copy link
Member

@matthewfeickert matthewfeickert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍 Thanks @alexander-held!

@matthewfeickert matthewfeickert merged commit e7c0fce into scikit-hep:master Nov 11, 2021
@alexander-held alexander-held deleted the docs/pruning-docstring-lists branch November 11, 2021 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workspace.prune only accepts lists
3 participants