Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Turn off PyPI release tests on pull requests #1664

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

matthewfeickert
Copy link
Member

Description

At the moment, the PyPI release tests run on pull requests

name: Current Release
on:
pull_request:

but this doesn't add much value and once we know that we've broken the public API there isn't much benefit in being reminded of this every PR. This PR just lets them continue to run nightly and on demand.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Turn off running PyPI release tests on pull requests given limited value add
* Use 'include' keyword over 'exclude' to reduce test matrix maintenance

@matthewfeickert matthewfeickert added the CI CI systems, GitHub Actions label Oct 22, 2021
@matthewfeickert matthewfeickert self-assigned this Oct 22, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1664 (1901e8d) into master (9fbbbf9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1664   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files          64       64           
  Lines        4216     4216           
  Branches      585      585           
=======================================
  Hits         4135     4135           
  Misses         48       48           
  Partials       33       33           
Flag Coverage Δ
contrib 25.30% <ø> (ø)
doctest 61.05% <ø> (ø)
unittests 96.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fbbbf9...1901e8d. Read the comment docs.

@matthewfeickert matthewfeickert merged commit f5dab71 into master Oct 22, 2021
@matthewfeickert matthewfeickert deleted the ci/remove-release-tests-from-prs branch October 22, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI systems, GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants