Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add uproot4 writing speedup to v0.6.3 release notes #1601

Merged
merged 3 commits into from
Sep 14, 2021

Conversation

matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Sep 13, 2021

Description

Retroactively make mention of the speedup in workspace conversion from JSON to XML + ROOT with the improvements in uproot v4.1.1. This was noticed by @alexander-held and is thanks to @jpivarski fixing a bug in scikit-hep/uproot5#426.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* Add large speedup of workspace conversion from JSON to XML + ROOT with uproot v4.1.1 to pyhf v0.6.3 release notes
   - c.f. https://github.com/scikit-hep/uproot4/pull/426

@matthewfeickert matthewfeickert added the docs Documentation related label Sep 13, 2021
@matthewfeickert matthewfeickert self-assigned this Sep 13, 2021
@codecov
Copy link

codecov bot commented Sep 13, 2021

Codecov Report

Merging #1601 (348c43b) into master (e72a780) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1601   +/-   ##
=======================================
  Coverage   97.70%   97.70%           
=======================================
  Files          63       63           
  Lines        4050     4050           
  Branches      576      576           
=======================================
  Hits         3957     3957           
  Misses         54       54           
  Partials       39       39           
Flag Coverage Δ
contrib 25.43% <ø> (ø)
unittests 97.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e72a780...348c43b. Read the comment docs.

@matthewfeickert
Copy link
Member Author

@kratsg kratsg merged commit 9d9d270 into master Sep 14, 2021
@kratsg kratsg deleted the docs/add-uprtoo4-write-speedup branch September 14, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants