Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set only lower bounds on core dependencies #1382

Merged
merged 39 commits into from
Mar 27, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
0952569
change bounds on core defaults to be >=
matthewfeickert Mar 26, 2021
101ee71
Change all of them
matthewfeickert Mar 26, 2021
8e54d20
Revert depandabot PR
matthewfeickert Mar 26, 2021
35307cb
Push core deps back
matthewfeickert Mar 26, 2021
2334584
lower in setup.cfg as well
matthewfeickert Mar 26, 2021
0ba8601
REMOVE: run on push
matthewfeickert Mar 26, 2021
cd4c2ac
Try with jsonschema 3.0.0
matthewfeickert Mar 26, 2021
87c2519
Try with click 5.0
matthewfeickert Mar 26, 2021
aa7940a
try jsonpatch v1.0
matthewfeickert Mar 26, 2021
1baff21
Better specify in setup.cfg
matthewfeickert Mar 26, 2021
7eb527f
Force lowest bound in lower-bound-requirements test
matthewfeickert Mar 26, 2021
a3d88a9
Try Click v1.0
matthewfeickert Mar 26, 2021
0e88d51
Temporarily back off to Click v5.0
matthewfeickert Mar 26, 2021
3f381ac
try backing off to jsonpatch v1.4
matthewfeickert Mar 26, 2021
f9da419
DELETE: TEMPORAIRLY DONT RUN CI ON PUSH
matthewfeickert Mar 26, 2021
2a3850b
try backing off to jsonpatch v1.10
matthewfeickert Mar 26, 2021
d6e1f8b
provide expected lower bounds and then force
matthewfeickert Mar 26, 2021
56e5ebe
try backing off to jsonpatch v1.13
matthewfeickert Mar 26, 2021
a05ff6a
Ensure click isn't doing weird stuff
matthewfeickert Mar 26, 2021
e907428
try backing off to jsonpatch v1.15
matthewfeickert Mar 26, 2021
387d8a0
try jsonpatch v1.14
matthewfeickert Mar 26, 2021
91e3319
try pyyaml v3.01
matthewfeickert Mar 26, 2021
0a3e1d2
Estalbish jsonpatch v1.15 as LOWER BOUND
matthewfeickert Mar 26, 2021
b96d798
try pyyaml v3.10
matthewfeickert Mar 26, 2021
b712cae
Try click v1.0
matthewfeickert Mar 26, 2021
71ae700
try backing off to click v2.0
matthewfeickert Mar 26, 2021
fa15ef2
try backing off to pyyaml v3.11
matthewfeickert Mar 26, 2021
73fbddb
try backing off to pyyaml v3.13
matthewfeickert Mar 26, 2021
b8a75a2
try backing off to click v3.0
matthewfeickert Mar 26, 2021
a92a68a
try backing off to click v4.0
matthewfeickert Mar 26, 2021
e5f8942
try click v3.3
matthewfeickert Mar 26, 2021
7e75730
TEST: CHECKOUT PR 1383 safe_load for pyyaml v3.13
matthewfeickert Mar 26, 2021
f254876
test only pyyaml 3.13 and not click
matthewfeickert Mar 26, 2021
a1aeb50
try click v4.0 and pyyaml v3.13
matthewfeickert Mar 26, 2021
80d2311
try click v4.0 and pyyaml 5.1
matthewfeickert Mar 26, 2021
8fd9690
Revert "TEST: CHECKOUT PR 1383 safe_load for pyyaml v3.13"
matthewfeickert Mar 26, 2021
a4f022d
try backing off to click v5.0
matthewfeickert Mar 26, 2021
1a03902
restore run settings on CI
matthewfeickert Mar 26, 2021
04b4732
Establish click v7.0 as LOWER BOUND....again
matthewfeickert Mar 26, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/lower-bound-requirements.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,12 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
- name: Install dependencies and force lowest bound
run: |
python -m pip install --upgrade pip setuptools wheel
python -m pip install --no-cache-dir --requirement lower-bound-requirements.txt
python -m pip install --quiet --no-cache-dir --requirement lower-bound-requirements.txt
python -m pip install --quiet --no-cache-dir --editable .[test]
python -m pip install --no-cache-dir --upgrade --requirement lower-bound-requirements.txt
python -m pip list
- name: Test with pytest
run: |
Expand Down
8 changes: 4 additions & 4 deletions lower-bound-requirements.txt
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
# core
scipy==1.4.1 # c.f. PR #1001
click==7.0.0
click==7.0
tqdm==4.56.0
jsonschema==3.2.0
jsonpatch==1.23.0
pyyaml==5.4
jsonschema==3.0.0
jsonpatch==1.15
pyyaml==5.1
# xmlio
uproot3==3.14.1
uproot==4.0.0
Expand Down
12 changes: 6 additions & 6 deletions setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,12 @@ packages = find:
include_package_data = True
python_requires = >=3.7
install_requires =
scipy~=1.4 # requires numpy, which is required by pyhf and tensorflow
click~=7.0 # for console scripts
tqdm~=4.56 # for readxml
jsonschema~=3.2 # for utils
jsonpatch~=1.23
pyyaml>=5.4 # for parsing CLI equal-delimited options
scipy>=1.4.1 # requires numpy, which is required by pyhf and tensorflow
click>=7.0 # for console scripts
tqdm>=4.56.0 # for readxml
jsonschema>=3.0.0 # for utils
jsonpatch>=1.15
pyyaml>=5.1 # for parsing CLI equal-delimited options

[options.packages.find]
where = src
Expand Down