Skip to content
This repository has been archived by the owner on Mar 31, 2019. It is now read-only.

add support for exporting to TH2 #51

Merged
merged 1 commit into from
Oct 26, 2018
Merged

Conversation

clelange
Copy link
Contributor

This is a first attempt at addressing #47. I think there are no tests for this in this package, since it's not easy to test with ROOT. I hope I got the axes the right way round. Please let me know what you think. I tried to follow the code style in the class. If this is fine, I can probably extend this further to cover a larger part of the currently unimplemented cases.

I can provide an example notebook.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 186

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 50.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
histbook/export.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
histbook/book.py 1 74.92%
histbook/util/init.py 1 58.33%
histbook/calc/init.py 2 87.4%
histbook/expr.py 12 83.09%
Totals Coverage Status
Change from base Build 185: -0.1%
Covered Lines: 2623
Relevant Lines: 5155

💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 186

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 50.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
histbook/export.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
histbook/book.py 1 74.92%
histbook/util/init.py 1 58.33%
histbook/calc/init.py 2 87.4%
histbook/expr.py 12 83.09%
Totals Coverage Status
Change from base Build 185: -0.1%
Covered Lines: 2623
Relevant Lines: 5155

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 186

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 50.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
histbook/export.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
histbook/book.py 1 74.92%
histbook/util/init.py 1 58.33%
histbook/calc/init.py 2 87.4%
histbook/expr.py 12 83.09%
Totals Coverage Status
Change from base Build 185: -0.1%
Covered Lines: 2623
Relevant Lines: 5155

💛 - Coveralls

@coveralls
Copy link

coveralls commented Oct 26, 2018

Pull Request Test Coverage Report for Build 186

  • 0 of 13 (0.0%) changed or added relevant lines in 1 file are covered.
  • 16 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 50.883%

Changes Missing Coverage Covered Lines Changed/Added Lines %
histbook/export.py 0 13 0.0%
Files with Coverage Reduction New Missed Lines %
histbook/book.py 1 74.92%
histbook/util/init.py 1 58.33%
histbook/calc/init.py 2 87.4%
histbook/expr.py 12 83.09%
Totals Coverage Status
Change from base Build 185: -0.1%
Covered Lines: 2623
Relevant Lines: 5155

💛 - Coveralls

@jpivarski
Copy link
Member

This looks good to me and doesn't break any tests (the code coverage going down by 0.1% does not concern me). I'll accept it and increase the version number so that it can go to PyPI.

Thanks!

@jpivarski jpivarski merged commit f0cc5bf into scikit-hep:master Oct 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants