Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated cd.yml workflow, following upstream fix #2

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jpivarski
Copy link
Member

Your issue with cd.yml (continuous deployment) not working was resolved in scientific-python/cookie#282. I'm just copying the fix here.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Your issue with cd.yml (continuous deployment) not working was resolved in scientific-python/cookie#282. I'm just copying the fix here.
@jpivarski
Copy link
Member Author

The test is running here: https://github.com/zbilodea/Proteus/actions/runs/6240154817

It should pass.

@jpivarski jpivarski requested a review from zbilodea September 19, 2023 19:38
@jpivarski
Copy link
Member Author

It did! (The "Publish to PyPI" step was deliberately skipped. It's a dry-run.)

Copy link
Collaborator

@zbilodea zbilodea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find!

@zbilodea zbilodea merged commit c9f7cb6 into main Oct 16, 2023
13 checks passed
@zbilodea zbilodea deleted the jpivarski/fix-workflow-cd branch October 16, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants