feat: make POI optional in config and allow POI customization for inference #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in scikit-hep/pyhf#1638 and scikit-hep/pyhf#1636 made POIs in
pyhf
workspaces optional. This means they can also be optional for thecabinetry
config when building models. If not specified, the POI defaults to""
which is interpreted as "no POI" bypyhf
.A new keyword argument
poi_name
was added tofit.ranking
andfit.limit
to override the POI given in the model config.Also fixing a deprecation warning observed in a test.
resolves #347