feat: parameter customization for maximum likelihood fits #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds customization to maximum likelihood fits via
fit.fit
:init_pars
,fix_pars
,par_bounds
.The names of the kwargs generally follow the
pyhf
naming, howeverfix_pars
currently differs from the currently usedfixed_params
used inpyhf
(scikit-hep/pyhf#1757). A harmonization inpyhf
should probably be propagated tocabinetry
as well in case it happens.This change revealed a small type inconsistency in
pyhf
-provided default parameter bounds, which is being followed up in scikit-hep/pyhf#1755.