Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename Form to form_cls #1976

Merged
merged 1 commit into from
Dec 8, 2022
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Dec 8, 2022

This renames Content.Form to Content.form_cls, which is better in line with the PEP8 naming conventions


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-refactor-rename-form/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1976 (efcafea) into main (8273e2e) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/bitmaskedarray.py 69.33% <100.00%> (ø)
src/awkward/contents/bytemaskedarray.py 88.46% <100.00%> (ø)
src/awkward/contents/content.py 75.93% <100.00%> (ø)
src/awkward/contents/emptyarray.py 72.58% <100.00%> (ø)
src/awkward/contents/indexedarray.py 77.56% <100.00%> (ø)
src/awkward/contents/indexedoptionarray.py 88.67% <100.00%> (ø)
src/awkward/contents/listarray.py 90.50% <100.00%> (ø)
src/awkward/contents/listoffsetarray.py 79.79% <100.00%> (ø)
src/awkward/contents/numpyarray.py 90.44% <100.00%> (ø)
src/awkward/contents/recordarray.py 84.53% <100.00%> (ø)
... and 3 more

@agoose77 agoose77 requested review from ioanaif and removed request for jpivarski December 8, 2022 14:02
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea; let's merge it!

@agoose77 agoose77 merged commit 5b754e3 into main Dec 8, 2022
@agoose77 agoose77 deleted the agoose77/refactor-rename-form branch December 8, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants