-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: make Content
initialisers take nplike
, parameters
as keyword
#1921
Conversation
Codecov Report
Additional details and impacted files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but also for Forms and Types, since there's a strong symmetry between these and Contents (especially Forms).
I'll get started on that, adding to this PR, if that's alright.
Fab, thanks for making this change. I was tempted to do them in multiple PRs, but on second thought it's less churn to do it all now. I didn't give it too much thought as I was playing around with You can see the config that I used to do these renames, run with semgrep -a --config=./rename.yaml
|
We were thinking along the same lines: I wanted to make them separate commits, rather than separate PRs, so that they can be checked in stages. It's just a question of what granularity the |
I ran a check over the forms with rules:
- id: single-arg
patterns:
- pattern: '$F(...)'
- pattern-not: '$F(..., parameters=$X)'
- metavariable-regex:
metavariable: $F
regex: ^.*Type$
languages: [python]
severity: WARNING
message: Semgrep found a match and visually ensured the correct results |
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-refactor-content-keyword/ once Read the Docs has finished building 🔨