Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add @ioana's tests of to_arraylib. #1908

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Nov 22, 2022


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-add-ioanas-test-of-to_arraylib/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1908 (addf623) into main (bacbab5) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Copy link
Collaborator

@ioanaif ioanaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ioanaif ioanaif enabled auto-merge (squash) November 22, 2022 17:46
@ioanaif ioanaif merged commit 3894053 into main Nov 22, 2022
@ioanaif ioanaif deleted the jpivarski/add-ioanas-test-of-to_arraylib branch November 22, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2 implementation of to_arraylib is missing cases from the original v1 to_numpy
2 participants