Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: import awkward._v2 now raises an explanatory error message. #1857

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

jpivarski
Copy link
Member

@jpivarski jpivarski commented Nov 1, 2022

This is a follow-up of #1771 (comment).

If you think this can be handled better, let me know here. Otherwise, this is how we'll retire the use of awkward._v2.

Cc: @agoose77, @douglasdavis, @martindurant, @alexander-held, @henryiii


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/jpivarski-v2-ModuleNotFoundError-message/ once Read the Docs has finished building 🔨

@jpivarski jpivarski linked an issue Nov 1, 2022 that may be closed by this pull request
@jpivarski
Copy link
Member Author

Oh, this is an open call for reviewers. I'll leave this open until our regular meeting on Thursday.

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1857 (45839f3) into main (87049ac) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 45839f3 differs from pull request most recent head c92ec80. Consider uploading reports for the commit c92ec80 to get more accurate results

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/__init__.py 96.96% <ø> (-0.09%) ⬇️
src/awkward/_v2.py 0.00% <0.00%> (-100.00%) ⬇️
src/awkward/contents/indexedarray.py 76.60% <0.00%> (-0.19%) ⬇️
src/awkward/contents/recordarray.py 83.87% <0.00%> (-0.19%) ⬇️
src/awkward/_util.py 82.21% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.90% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️

Copy link
Member

@alexander-held alexander-held left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great solution! I gave the changes a try and everything works as expected.

@douglasdavis
Copy link
Contributor

+1

@jpivarski jpivarski merged commit edc0d67 into main Nov 3, 2022
@jpivarski jpivarski deleted the jpivarski/v2-ModuleNotFoundError-message branch November 3, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

awkward._v2 imports broken with subpackages
4 participants