-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add rdataframe user guide #1836
Conversation
Codecov Report
Additional details and impacted files
|
The two aren't compatible, and we can use ROOTs' C++ kernel
@jpivarski I've touched this PR, so it would be best if you were the reviewer. I've switched the CI from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! (I viewed the rendered docs as well.)
My only complaint is the commented-out code (below). Once that's gone, fee free to merge!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpivarski - @agoose77 argument seems convincing. If it resolves the conversation, please, merge it.
📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/ianna-rdataframe-user-guide-v1/ once Read the Docs has finished building 🔨