Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: visit all layout nodes with ak.fill_none(..., axis=None) #1830

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 25, 2022

Fixes #1823


📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-fix-fill-none-axis-none/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #1830 (37ff8be) into main (2bdd114) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/operations/ak_fill_none.py 94.87% <100.00%> (+5.12%) ⬆️
src/awkward/contents/indexedarray.py 79.46% <0.00%> (-0.20%) ⬇️
src/awkward/_util.py 82.36% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.90% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️
src/awkward/contents/recordarray.py 83.94% <0.00%> (+0.03%) ⬆️
src/awkward/contents/content.py 77.31% <0.00%> (+0.10%) ⬆️

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test and nice fix!

@jpivarski jpivarski merged commit 5ed5358 into main Oct 25, 2022
@jpivarski jpivarski deleted the agoose77/fix-fill-none-axis-none branch October 25, 2022 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ak.fill_none(axis=None) does nothing
2 participants