Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use custom PR message action #1816

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Oct 20, 2022

I tried to use the RTD action in #1812, but it transpires that this leverages the RTD GitHub integration that we aren't using. We couldn't see this until it made it into a base branch, so I only discovered it after the merge.

So, this PR

  • Roll our own PR message editing machinery.
  • Replace Python with bash (avoid Python step in job).
  • Bundle new JS to edit commit message.

📚 The documentation for this PR will be available at https://awkward-array.readthedocs.io/en/agoose77-docs-disable-pr-link/ once Read the Docs has finished building 🔨

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1816 (6beb189) into main (2511d4b) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/contents/indexedarray.py 79.76% <0.00%> (-0.19%) ⬇️
src/awkward/contents/recordarray.py 83.72% <0.00%> (-0.18%) ⬇️
src/awkward/_util.py 82.36% <0.00%> (-0.18%) ⬇️
src/awkward/contents/indexedoptionarray.py 88.92% <0.00%> (-0.16%) ⬇️
src/awkward/_connect/avro.py 87.17% <0.00%> (-0.14%) ⬇️
src/awkward/types/_awkward_datashape_parser.py 47.72% <0.00%> (-0.01%) ⬇️
src/awkward/contents/content.py 77.31% <0.00%> (+0.10%) ⬆️

@agoose77 agoose77 changed the title ci: use in-house PR message action ci: use custom PR message action Oct 20, 2022
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have asked if we should switch to the GitHub ReadTheDocs Integration, but you've already adapted to the interface we have.

I'll merge this and we'll see if it works. I got your message that you intentionally cancelled the build because it isn't testing anything; I'll use the red button to merge without successful tests.

(Fingers in ears...)

@jpivarski jpivarski merged commit 569f183 into main Oct 20, 2022
@jpivarski jpivarski deleted the agoose77/docs-disable-pr-link branch October 20, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants