Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: carry parameters through broadcasting #1679

Merged
merged 19 commits into from
Sep 7, 2022
Merged

fix: carry parameters through broadcasting #1679

merged 19 commits into from
Sep 7, 2022

Commits on Sep 7, 2022

  1. test: add test for #1162

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    535f5ce View commit details
    Browse the repository at this point in the history

  2. feat: allow internal routines to change parameter broadcasting 

    This introduces new parameter broadcasting modes:
- `INTERSECT`
- `ONE_TO_ONE`
- `ALL_OR_NOTHING`
- `NONE`

The previous default was `None`.

The meaning of these broadcasting modes, set using the `"broadcast_parameters_rule"` option key, can be found in the source code.
    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    846e349 View commit details
    Browse the repository at this point in the history

  3. fix: support non-Contents in broadcasting

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c3bcfdf View commit details
    Browse the repository at this point in the history

  4. fix: use backwards-compatible annotations

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5610456 View commit details
    Browse the repository at this point in the history

  5. style: small code organisation changes

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    eb93ef1 View commit details
    Browse the repository at this point in the history

  6. style: use lowercase enums

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    7407484 View commit details
    Browse the repository at this point in the history

  7. fix: ensure parameter checking considers None parameters nonexisting

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    87eb63d View commit details
    Browse the repository at this point in the history

  8. feat: add broadcast_parameters_rule option to ak.transform

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b0215e1 View commit details
    Browse the repository at this point in the history

  9. fix: use enum to set default broadcasting value

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    586def1 View commit details
    Browse the repository at this point in the history

  10. docs: improve docstrings

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1c07055 View commit details
    Browse the repository at this point in the history

  11. docs: fix typo in description

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    81c48a9 View commit details
    Browse the repository at this point in the history

  12. fix: also handle unions and options

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a56ab17 View commit details
    Browse the repository at this point in the history

  13. test: improve coverage and add new option tests

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    052f421 View commit details
    Browse the repository at this point in the history

  14. refactor: improve error message

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6dc6d4b View commit details
    Browse the repository at this point in the history

  15. test: cover transform test cases

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5db378a View commit details
    Browse the repository at this point in the history

  16. docs: remove half-written comment

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    878c6be View commit details
    Browse the repository at this point in the history

  17. docs: add docstring to _parameters_is_empty

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    3b693f0 View commit details
    Browse the repository at this point in the history

  18. fix: catch missing case

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e013057 View commit details
    Browse the repository at this point in the history

  19. test: test missing case

    @agoose77
    agoose77 committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cbf4c35 View commit details
    Browse the repository at this point in the history