Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include self._length in RegularArray.mergemany #1645

Merged
merged 3 commits into from
Aug 31, 2022

Conversation

agoose77
Copy link
Collaborator

Fixes #1644

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #1645 (f56041d) into main (9e17f29) will increase coverage by 0.46%.
The diff coverage is 63.67%.

Additional details and impacted files
Impacted Files Coverage Δ
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/_connect/numexpr.py 88.40% <0.00%> (ø)
src/awkward/_v2/_connect/pyarrow.py 88.46% <0.00%> (ø)
...awkward/_v2/_connect/rdataframe/from_rdataframe.py 0.00% <0.00%> (ø)
...c/awkward/_v2/_connect/rdataframe/to_rdataframe.py 0.00% <0.00%> (ø)
src/awkward/_v2/_lookup.py 98.68% <ø> (+1.17%) ⬆️
src/awkward/_v2/numba.py 93.47% <0.00%> (ø)
src/awkward/_v2/operations/ak_from_avro_file.py 66.66% <0.00%> (ø)
src/awkward/_v2/operations/ak_local_index.py 100.00% <ø> (ø)
src/awkward/_v2/operations/ak_max.py 87.09% <ø> (ø)
... and 63 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely the right fix. (I just tried it out.)

I think the mistake was made when I was thinking that others is the full set of things to merge, forgetting that self should also be in that set?

@agoose77
Copy link
Collaborator Author

I think the mistake was made when I was thinking that others is the full set of things to merge, forgetting that self should also be in that set?

Yep, I think that's probably how it happened :)

@jpivarski jpivarski enabled auto-merge (squash) August 31, 2022 22:13
@jpivarski jpivarski merged commit eede724 into main Aug 31, 2022
@jpivarski jpivarski deleted the agoose77/fix-concatenate-zeros-length branch August 31, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistency in ak.concatenate when dim length is zero
2 participants