Fix/Fixed slicing shape for array of booleans #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
|
jpivarski
approved these changes
Jun 10, 2022
Comment on lines
-62
to
+64
| out.append(ak._v2.index.Index64(nplike.nonzero(x)[0])) | ||
| out[-1].metadata["shape"] = x.shape | ||
| current = ak._v2.index.Index64(nplike.nonzero(x)[0]) | ||
| out.append(current) | ||
| out[-1].metadata["shape"] = current.data.shape |
There was a problem hiding this comment.
That makes a lot of sense: the shape had been wrong because at some point, we made the assumption that x is an array of integer positions, but here it's an array of booleans, unlike what goes into out. If this was the case, the following should have worked (pre-bug-fix), because the shape of the booleans and the shape of the integers is the same:
>>> ak._v2.Array([[1.1, 2.2, 3.3], [4.4], [5.5, 6.6]])[[True, True, True], 0]
<Array [1.1, 4.4, 5.5] type='3 * float64'>and it did.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1495