-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LayoutBuilder migration to v2 #1484
Conversation
Codecov Report
|
080420a
to
956c8de
Compare
@jpivarski - Please, have a look when you have time. This PR completes migration of LayoutBuilder to v2. Although it is not intended to be a long term solution, I think, it is useful to have it in the main branch. We want to compare performance of the old implementation with the new one. The PR implements a high level interface to a current LayoutBuilder that we will swap with the one in development. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We want to compare performance of the old implementation with the new one. The PR implements a high level interface to a current LayoutBuilder that we will swap with the one in development.
Okay, that makes sense, though it would also work to do the performance study before v1 is removed. But more flexibility is better than less.
It's a good update, so I'll merge it!
No description provided.