Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LayoutBuilder migration to v2 #1484

Merged
merged 27 commits into from
Jul 1, 2022
Merged

Conversation

ianna
Copy link
Collaborator

@ianna ianna commented May 31, 2022

No description provided.

@ianna ianna marked this pull request as draft May 31, 2022 20:34
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1484 (ed55358) into main (b0dced7) will decrease coverage by 0.12%.
The diff coverage is 57.60%.

Impacted Files Coverage Δ
src/awkward/_v2/highlevel.py 69.81% <57.60%> (-2.58%) ⬇️
src/awkward/_v2/_connect/jax/__init__.py 88.88% <0.00%> (-1.59%) ⬇️
src/awkward/_v2/operations/ak_from_parquet.py 49.15% <0.00%> (-0.85%) ⬇️
src/awkward/_v2/_slicing.py 84.00% <0.00%> (-0.70%) ⬇️
src/awkward/_v2/_broadcasting.py 94.00% <0.00%> (ø)
src/awkward/_v2/behaviors/string.py 77.24% <0.00%> (ø)
src/awkward/_v2/contents/content.py 76.61% <0.00%> (ø)
src/awkward/_v2/contents/listarray.py 91.79% <0.00%> (ø)
src/awkward/_v2/contents/unionarray.py 86.27% <0.00%> (ø)
src/awkward/_v2/operations/ak_where.py 91.66% <0.00%> (ø)
... and 21 more

@ianna ianna force-pushed the ianna/layout-buffer-refactoring branch from 080420a to 956c8de Compare June 1, 2022 14:39
@ianna ianna marked this pull request as ready for review July 1, 2022 07:42
@ianna
Copy link
Collaborator Author

ianna commented Jul 1, 2022

@jpivarski - Please, have a look when you have time. This PR completes migration of LayoutBuilder to v2. Although it is not intended to be a long term solution, I think, it is useful to have it in the main branch. We want to compare performance of the old implementation with the new one. The PR implements a high level interface to a current LayoutBuilder that we will swap with the one in development. Thanks!

@ianna ianna requested a review from jpivarski July 1, 2022 07:47
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to compare performance of the old implementation with the new one. The PR implements a high level interface to a current LayoutBuilder that we will swap with the one in development.

Okay, that makes sense, though it would also work to do the performance study before v1 is removed. But more flexibility is better than less.

It's a good update, so I'll merge it!

@jpivarski jpivarski merged commit 0cdabf6 into main Jul 1, 2022
@jpivarski jpivarski deleted the ianna/layout-buffer-refactoring branch July 1, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants