Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: from_numpy references ListArray64 #1404

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Fix: from_numpy references ListArray64 #1404

merged 2 commits into from
Apr 8, 2022

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Apr 8, 2022

Fixes #1403

@agoose77 agoose77 requested a review from jpivarski April 8, 2022 11:53
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1404 (b58e02f) into main (a8c37b9) will increase coverage by 0.41%.
The diff coverage is 73.82%.

Impacted Files Coverage Δ
src/awkward/_v2/_broadcasting.py 93.71% <ø> (ø)
src/awkward/_v2/_connect/cling.py 0.00% <ø> (ø)
src/awkward/_v2/_connect/cuda/__init__.py 0.00% <0.00%> (ø)
src/awkward/_v2/contents/listarray.py 90.80% <ø> (+2.62%) ⬆️
src/awkward/_v2/operations/structure/ak_mask.py 95.23% <ø> (ø)
src/awkward/_v2/highlevel.py 74.31% <65.90%> (+1.19%) ⬆️
src/awkward/_v2/operations/convert/ak_to_layout.py 81.81% <75.00%> (-2.06%) ⬇️
src/awkward/_v2/_connect/numpy.py 62.24% <80.00%> (+0.46%) ⬆️
src/awkward/_v2/_util.py 83.33% <86.40%> (+4.12%) ⬆️
src/awkward/_v2/types/recordtype.py 83.69% <87.50%> (+0.16%) ⬆️
... and 14 more

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I had realized how easy this one was going to be, I'd have gotten to it sooner! Absolutely a good fix. I'm glad that it's passing through tests now.

(The reason I added the Codecov tool was in anticipation of a future campaign to increase coverage. It doesn't have to be 100%, but it should someday include all the lines like this.)

@jpivarski jpivarski merged commit edfce38 into main Apr 8, 2022
@jpivarski jpivarski deleted the fix-from_numpy branch April 8, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from_numpy fails for string dtypes (v2)
2 participants