ak.flatten and ak.ravel should test for nplike.ndarray, not np.ndarray.

[jpivarski]

No description provided.

[codecov]

Codecov Report

Merging #1340 (6159651) into main (b2fd2be) will not change coverage.
The diff coverage is 100.00%.

Impacted Files	Coverage Δ
src/awkward/_v2/operations/structure/ak_flatten.py	91.42% <100.00%> (ø)
src/awkward/_v2/operations/structure/ak_ravel.py	90.90% <100.00%> (ø)

[agoose77]

@jpivarski Not sure if this is helpful, but I did a quick grep and found a few other places in v2 where we reference np.ndarray, e.g. ak.type. I didn't check whether they're actually resolving against numpy.ndarray, or if the usage is acceptable.

[jpivarski]

Do you mean these two?

https://github.com/scikit-hep/awkward-1.0/blob/61596516352066437e602040f0e89eb2d8a78a79/src/awkward/_v2/operations/structure/ak_fill_none.py#L54-L74

Actually, these are the fill_value for ak.fill_none, and they're coming from the user—NumPy arrays are one of the possible input types. The other cases I came across are similar.

Which cases are you talking about?

[jpivarski]

ak.type is also just checking possible user inputs, which includes np.ndarray.

The thing that had to be fixed here is that these arrays are coming out of a layout (layout.completely_flatten(...)), and so they'd have whatever array type the nplike says. That's a different context from data that comes from a user.

[agoose77]

Sure, I might be missing the obvious here. Is it possible that a user will knowingly call ak.XXX functions on TypeTracerArray? Is that a useful thing that a keen user might wish to do?

[jpivarski]

It shouldn't be possible. The TypeTracer was created just to support Dask, though you may have found another good use for it in avoiding duplication between Content methods and Form methods.

It's in a module named with an underscore—there's no way to make one without invoking private code (so not even "mid-level," really "low-level"!). A user might get one from a Dask Awkward Array's meta, but hopefully this is considered private, too.

That doesn't preclude the possibility of accidents (bugs), but users aren't supposed to be able to see them.

[jpivarski]

It looks like this is safe for me to merge (no more work to do).