C++ refactoring: ak.concatenate

[ioanaif]

No description provided.

[codecov]

Codecov Report

Merging #1161 (3a3c91c) into main (f795658) will increase coverage by 1.56%.
The diff coverage is 76.45%.

Impacted Files	Coverage Δ
src/awkward/_v2/forms/bitmaskedform.py	75.64% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py	76.05% <ø> (ø)
src/awkward/_v2/forms/emptyform.py	78.84% <ø> (+1.92%)	⬆️
src/awkward/_v2/forms/indexedoptionform.py	76.81% <ø> (ø)
src/awkward/_v2/forms/listform.py	75.94% <ø> (ø)
src/awkward/_v2/forms/listoffsetform.py	81.94% <ø> (+1.38%)	⬆️
src/awkward/_v2/forms/recordform.py	66.46% <ø> (ø)
src/awkward/_v2/forms/regularform.py	75.34% <ø> (ø)
src/awkward/_v2/forms/unionform.py	76.19% <ø> (ø)
src/awkward/_v2/forms/unmaskedform.py	74.57% <ø> (ø)
... and 78 more

[jpivarski]

I can see how much went into this—thank you! However, I wasn't clear enough about the new broadcast_and_apply and recursively_apply interfaces, which are in _broadcasting.py and the Content class, respectively. What you've done below takes us to 90% of the implementation, but some arguments need to change to use the new interfaces. After that, the broadcast_and_apply and transform/transform_layouts functions you ported in _v2/_util.py won't be needed.

[jpivarski]

Thank you very much for fixing that (and finding a few untested parts of _broadcasting.py). The commit I just made was to remove some commented-out code, that's all. It's set to auto-merge when the tests pass again.

[ioanaif]

Thank you very much for fixing that (and finding a few untested parts of _broadcasting.py). The commit I just made was to remove some commented-out code, that's all. It's set to auto-merge when the tests pass again.

Thank you! Great! Happy to have this merged!

[douglasdavis]

Woohoo! Thanks for this 😄