Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace leaf Nones with +-inf for argmin/argmax axis=None. #1156

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski enabled auto-merge (squash) November 17, 2021 15:41
@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #1156 (72d8652) into main (f795658) will increase coverage by 0.44%.
The diff coverage is 76.66%.

Impacted Files Coverage Δ
src/awkward/_v2/forms/bitmaskedform.py 75.64% <ø> (ø)
src/awkward/_v2/forms/bytemaskedform.py 76.05% <ø> (ø)
src/awkward/_v2/forms/emptyform.py 76.92% <ø> (ø)
src/awkward/_v2/forms/indexedoptionform.py 76.81% <ø> (ø)
src/awkward/_v2/forms/listform.py 75.94% <ø> (ø)
src/awkward/_v2/forms/listoffsetform.py 80.55% <ø> (ø)
src/awkward/_v2/forms/recordform.py 66.46% <ø> (ø)
src/awkward/_v2/forms/regularform.py 75.34% <ø> (ø)
src/awkward/_v2/forms/unionform.py 76.19% <ø> (ø)
src/awkward/_v2/forms/unmaskedform.py 74.57% <ø> (ø)
... and 57 more

@jpivarski jpivarski merged commit 7705900 into main Nov 17, 2021
@jpivarski jpivarski deleted the jpivarski/argminmax-axis-None-missing-values branch November 17, 2021 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

argmax and argmin give incorrect results on option types when axis=None
1 participant