C++ refactoring: num() #1137

ioanaif · 2021-11-09T10:09:13Z

No description provided.

for more information, see https://pre-commit.ci

codecov · 2021-11-09T10:32:12Z

Codecov Report

Merging #1137 (f24eee1) into main (0b0fb3f) will increase coverage by 2.58%.
The diff coverage is 67.04%.

Impacted Files	Coverage Δ
src/awkward/_v2/behaviors/string.py	`100.00% <ø> (ø)`
src/awkward/_v2/forms/bitmaskedform.py	`75.64% <ø> (+7.69%)`	⬆️
src/awkward/_v2/forms/bytemaskedform.py	`76.05% <ø> (+7.04%)`	⬆️
src/awkward/_v2/forms/indexedform.py	`77.33% <ø> (+14.17%)`	⬆️
src/awkward/_v2/forms/unmaskedform.py	`74.57% <ø> (+5.08%)`	⬆️
src/awkward/_v2/highlevel.py	`51.70% <0.00%> (+16.59%)`	⬆️
.../awkward/_v2/operations/convert/ak_from_buffers.py	`85.85% <ø> (ø)`
src/awkward/_v2/operations/convert/ak_from_cupy.py	`80.00% <0.00%> (ø)`
src/awkward/_v2/operations/convert/ak_from_iter.py	`78.57% <ø> (ø)`
src/awkward/_v2/operations/convert/ak_from_jax.py	`80.00% <0.00%> (ø)`
... and 147 more

jpivarski

Except for AxisErrors (discussed in meeting):

raise np.AxisError("axis={0} exceeds the depth of this array ({1})".format(axis, depth))

num() addition for most arrays + tests

14a3718

ioanaif marked this pull request as draft November 9, 2021 10:09

ioanaif changed the title ~~C++ Refactoring: num()~~ C++ refactoring: num() Nov 9, 2021

[pre-commit.ci] auto fixes from pre-commit.com hooks

d7723d7

for more information, see https://pre-commit.ci

Addding num() for all contents and fixing all tests

08adb08

ioanaif marked this pull request as ready for review November 9, 2021 21:39

jpivarski approved these changes Nov 11, 2021

View reviewed changes

Switch to raise AxisError

f24eee1

ioanaif merged commit c75e1bc into main Nov 11, 2021

ioanaif deleted the ioanaif/num branch November 11, 2021 16:46